Conversation
The current OBC segment list includes a "segment zero" which corresponds to when the segment maps (segnum_u, segnum_v) point to OBC_NONE, which is set to zero. The purpose of this "segment zero" seems to be for avoiding invalid references, so that OBC%segment(OBC%segnum_[uv](i,j)) always returns a valid result, included when set to OBC_NONE. This results in reading and setting values which are unused or unneeded. This patch replaces these redundant accesses to segment zero with various conditional blocks for avoiding these accesses.
There were a few remaining segnum_[uv] references in MOM_open_boundary which could reference segment zero. This patch fixes those references.
…into remove_obc_seg0
OBC: Removal of segment zero
- Adds a diagnostic of the parameterized SGS T variance used in the Brankart correction to the PGF
- The SGS T variance is measure from the grid-scale variance. It should be a horizontal difference but is approximated as along coordinate. This adds thickness weighting to avoid large values near topography.
Brankart
pjpegion
pushed a commit
that referenced
this pull request
Apr 12, 2021
Update CPT fork of MOM6 to latest (12/10/2020) from NOAA-GFDL
pjpegion
pushed a commit
that referenced
this pull request
Jun 11, 2021
fix array size declaration and post_data
pjpegion
pushed a commit
that referenced
this pull request
Jul 28, 2021
Only write checksums from root PE MCT/NUOPC caps
pjpegion
pushed a commit
that referenced
this pull request
Jun 15, 2022
Correct a couple of typos in hor_visc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge in Alistair's updates to my stochastic branch